[Bug 437691] Review Request: monitor-edid - Tool for probing and parsing EDID

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 16 19:24:21 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: monitor-edid - Tool for probing and parsing EDID


https://bugzilla.redhat.com/show_bug.cgi?id=437691


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ville.skytta at iki.fi
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From ville.skytta at iki.fi  2008-03-16 15:24 EST -------
License: GPLv2 is incorrect.  The tarball includes COPYING which is the LGPLv2
text, but none of the source files have any GPL or LGPL references, instead they
have various BSD/MIT like notices.

Providing a checkout script would be more convenient than including comments in
the specfile.  Could also use svn export instead of checkout (does not checkout
.svn directories), and bzip2 or lzma the tarball instead of gzipping to save space.

Looks also like there's a private copy of lrmi in the tarball, is there a reason
why the Fedora packaged one is not used instead?

Including the word "monitor" in the Summary would be good.

Will continue the review after the license issues have been sorted out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list