[Bug 435835] Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 16 21:04:03 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling
Alias: perl-RPC-XML

https://bugzilla.redhat.com/show_bug.cgi?id=435835





------- Additional Comments From nsboyle at gmail.com  2008-03-16 17:04 EST -------
(In reply to comment #4)
> The %perl_vendorarch and %perl_vendorlib macros have been defined by the
> system since...  oh, about RHEL3 or so.  They should probably be dropped

Done.

> Your buildroot is slightly wonky; Fedora generally uses
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

The method I'm using is preferred as per the wiki; see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473

> You have the man pages marked %doc...  AFAIK convention is to not mark these as
> such, though I'm not entirely sure convention is correct in this case.

You're right, fixed

> The Apache::RPC::Server/::Status modules pull in mod_perl, which in turn has a
> slew of requirements of its own (not the least of which is apache).  I'd break
> them out into a subpackage to avoid a rather large potentially unwanted
> dependency tree.

Agreed... I wasn't sure of an appropriate name, so for now it's perl-Apache-RPC.
   If there's another way to name it that makes more sense, let me know! :)

> Your buildrequires are incomplete:  judging by Makefile.PL there are a couple
> more you're going to want to throw in there.  Note also that it's key to start
> including core modules such as Test::More if so required.

There is a warning about a missing XML::LibXML, but only to inform the user this
will be required under RPC-XML v0.60.  Other modules required in Makefile.PL,
that aren't in the spec, are part of the core perl package  (ex: Cwd, and
File::Find).

> It's often helpful to kick off a koji scratch build and post the link to the
> task results in the bug review (a relatively recent development).  It's also a
> good self-sanity check to ensure the package builds as intended.

This mock builds on 8 and devel i386 for me, without issue.  Additionally, it
scratch built in Koji for me:

F8: http://koji.fedoraproject.org/koji/taskinfo?taskID=518717
F9: http://koji.fedoraproject.org/koji/taskinfo?taskID=518727

Is there something specific you noticed in building that I'm overlooking?

At any rate, the package/subpackage version is now available here:
Spec URL: http://nboyle.fedorapeople.org/perl-RPC-XML.spec
SRPM URL: http://nboyle.fedorapeople.org/perl-RPC-XML-0.59-4.fc8.src.rpm

I've never really worked with the whole subpackage business, so please look over
that with extra scrutiny ;)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list