[Bug 433915] Review Request: unison213 - File synchronization tool (compatibility package)

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 17 03:19:05 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unison213 - File synchronization tool (compatibility package)


https://bugzilla.redhat.com/show_bug.cgi?id=433915


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: unison2.13 -|Review Request: unison213 -
                   |File synchronization tool   |File synchronization tool
                   |(compatibility package)     |(compatibility package)




------- Additional Comments From kevin at tummy.com  2008-03-16 23:19 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL+)
See below - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
a79bf5f4ebf2a1eaf15b1ac97f827374  unison-2.13.16.tar.gz
a79bf5f4ebf2a1eaf15b1ac97f827374  unison-2.13.16.tar.gz.orig
See below - Package needs ExcludeArch
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag

Issues:

1. Seems like all the source files here just say:
 Copyright 1999-2004 (see COPYING for details)
COPYING is just a copy of the GPL, so this would make the
project "GPL+" (ie, any version of the GPL).
Perhaps you can clarify with upstream what they intend here?

2. ocaml should now be available on ppc64, so you shouldn't need
to exclude that anymore. I did a scratch build here and it built fine on
ppc64:
http://koji.fedoraproject.org/koji/taskinfo?taskID=518984

3. rpmlint says:

unison213.x86_64: W: obsolete-not-provided unison

This can be ignored as this is the compat/lower version for the release.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list