[Bug 436036] Review Request: jna - Pure Java access to native libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jna - Pure Java access to native libraries


https://bugzilla.redhat.com/show_bug.cgi?id=436036





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-17 10:41 EST -------
For 3.0.2-3:

* License
  - License tag should be LGPLv2+

* BuildRequires
  - BR: libffi is not needed as libffi-devel Requires libffi.

! Explicit Requires
  - This package has explicit Requires: "Requires: libffi"
    - For this package this cannot be avoided because
      /usr/lib/rpm/redhat/find-requires cannot check the dependency
      for the libraries packaged in jar file.
    - However usually (i.e. for non-Java rpms) these type of
      dependency should be detected automatically by find-requires
      and this type of explicit Requires should not be written

     So would you write a comment in the spec file why
     this explicit Requires is needed?
     (and this issue must be discussed on making Java packaging 
      guidelines)

* Requires
  - Like joda-time, "Requires: %{name}-%{version}-%{release}"
    is wrong.

? .zip file
  - As far as I unzipped .zip files in jna tarball, all files in the zip
    ball are text files.
    However it this is not needed on rebuilding jna, please remove
    these.

* Some rpmlint complaint
-------------------------------------------------------------
jna.i386: W: spurious-executable-perm /usr/share/doc/jna-3.0.2/LICENSE.txt
jna.i386: E: wrong-script-end-of-line-encoding /usr/share/doc/jna-3.0.2/LICENSE.txt
-------------------------------------------------------------
  - The permission of LICENSE.txt should be 0644 and this file should
    not have CRLF end-of-line encoding.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.