[Bug 435829] Review Request: tomcat6 - Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 18 15:08:58 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tomcat6 -  Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API


------- Additional Comments From pcheung at redhat.com  2008-03-18 11:08 EST -------
Please fix item(s) mared by X:
* package is named appropriately
 - match upstream tarball or project name
 - try to match previous incarnations in other distributions/packagers for
 - specfile should be %{name}.spec
 - non-numeric characters should only be used in Release (ie. cvs or
 - for non-numerics (pre-release, CVS snapshots, etc.), see
 - if case sensitivity is requested by upstream or you feel it should be
   not just lowercase, do so; otherwise, use all lower case for the name
* is it legal for Fedora to distribute this?
 - OSI-approved
 - not a kernel module
 - not shareware
 - is it covered by patents?
 - it *probably* shouldn't be an emulator
 - no binary firmware
* license field matches the actual license.
* license is open source-compatible.
 - use acronyms for licences where common
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
 - if upstream doesn't release source drops, put *clear* instructions on
   how to generate the the source drop; ie. 
  # svn export blah/tag blah
  # tar cjf blah-version-src.tar.bz2 blah
* skim the summary and description for typos, etc.
* correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
We're keeping the buildroot as NVR as per discussed in the meeting with Fedora
and JPackage folks.
* if %{?dist} is used, it should be in that form (note the ? and %
* license text included in package and marked with %doc
* keep old changelog entries; use judgement when removing (too old?
* packages meets FHS (http://www.pathname.com/fhs/)
* rpmlint on <this package>.srpm gives no output
 - justify warnings if you think they shouldn't be there
* changelog should be in one of these formats:

  * Fri Jun 23 2006 Jesse Keating <jkeating at redhat.com> - 0.6-4
  - And fix the link syntax.

  * Fri Jun 23 2006 Jesse Keating <jkeating at redhat.com> 0.6-4
  - And fix the link syntax.

  * Fri Jun 23 2006 Jesse Keating <jkeating at redhat.com>
  - 0.6-4
  - And fix the link syntax.

* Packager tag should not be used
* Vendor tag should not be used
* Distribution tag should not be used
* use License and not Copyright 
* Summary tag should not end in a period
* if possible, replace PreReq with Requires(pre) and/or Requires(post)
X specfile is legible
 - in tomcat6-6.0.conf, JAVA_HOME is set to /usr/lib/jvm/java-icedtea, shouldn't
it be set to /usr/lib/jvm/java and set alternatives to set icedtea to be the jvm?
 - in tomcat6-6.0.init, should a check to see if the file
/etc/rc.d/init.d/functions exists before sourcing it?
 - should icedtea be listed as Requires as well?
 - is jpackage-utils a Requires as well?
 - is this the correct link for FHS 2.3:
* package successfully compiles and builds on at least x86
X BuildRequires are proper
 - builds in mock will flush out problems here
 - the following packages don't need to be listed in BuildRequires:
   fedora-release (and/or redhat-release)
X sed doesn't need to be listed as a BR.
* summary should be a short and concise description of the package
* description expands upon summary (don't include installation
* make sure lines are <= 80 characters
* specfile written in American English
* make a -doc sub-package if necessary
 - see
* packages including libraries should exclude static libraries if possible
* don't use rpath
* config files should usually be marked with %config(noreplace)
* GUI apps should contain .desktop files
* should the package contain a -devel sub-package?
* use macros appropriately and consistently
 - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
* don't use %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* locale data handling correct (find_lang)
 - if translations included, add BR: gettext and use %find_lang %{name} at the
   end of %install
* consider using cp -p to preserve timestamps
* split Requires(pre,post) into two separate lines
* package should probably not be relocatable
* package contains code
 - see http://fedoraproject.org/wiki/Packaging/Guidelines#CodeVsContent
 - in general, there should be no offensive content
* package should own all directories and files
* there should be no %files duplicates
* file permissions should be okay; %defattrs should be present
* %clean should be present
* %doc files should not affect runtime
* if it is a web apps, it should be in /usr/share/%{name} and *not* /var/www
* verify the final provides and requires of the binary RPMs
* run rpmlint on the binary RPMs

* package should include license text in the package and mark it with %doc
* package should build on i386
X package should build in mock
I'm getting:
Cannot find build req  java-devel-icedtea >= 0:1.5.0. Exiting.

I'll continue reviewing once I can build it in mock

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the package-review mailing list