[Bug 438083] Review Request: perl-Catalyst-View-TT - Template Toolkit View Class
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 19 01:42:48 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-View-TT - Template Toolkit View Class
https://bugzilla.redhat.com/show_bug.cgi?id=438083
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Status|NEW |ASSIGNED
Flag| |fedora-review+
------- Additional Comments From panemade at gmail.com 2008-03-18 21:42 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521583
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
653f58f818a1b0b3d0ad28b62c13241b Catalyst-View-TT-0.26.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=38, 1 wallclock secs ( 1.50 cusr + 0.21 csys = 1.71 CPU)
+ Package perl-Catalyst-View-TT-0.26-1.fc9 =>
Provides: perl(Catalyst::Helper::View::TT)
perl(Catalyst::Helper::View::TTSite) perl(Catalyst::View::TT) = 0.26
Requires: perl(Catalyst) perl(Data::Dump) perl(File::Spec) perl(NEXT)
perl(Path::Class) perl(Template) perl(Template::Timer) perl(base) perl(strict)
perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list