[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 27 19:27:52 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0


https://bugzilla.redhat.com/show_bug.cgi?id=439265





------- Additional Comments From walters at redhat.com  2008-03-27 15:27 EST -------
On an overall level, does Fedora really have all the current Netbeans
dependencies?  The Build-Depends is pretty short.  Does Netbeans ship a copy of
any libraries in source form even, not necessarily jar?

%setup -q -c
find . -type d | xargs -t chmod 755
find . -type f -exec chmod 644 {} ";"
find . -type f \( -iname "*.jar" -o -iname "*.zip" \) | xargs -t %{__rm} -f

Longer term, I'd try to have netbeans generate a clean source tarball/zip rather
than relying on this.

LNS="%{__ln_s}"
MKDIRP="%{__mkdir_p}"
JAVADIR="%{_javadir}"
JAVADOCDIR="$RPM_BUILD_ROOT/%{_javadocdir}/netbeans-platform7"
RMF="%{__rm} -rf"
INS="%{__cp} -r"
NBDIR="$RPM_BUILD_ROOT/%{clusterdir}"
JHJAR=javahelp2.jar
export LNS MKDIRP JAVADIR JAVADOCDIR RMF INS NBDIR JHJAR

A lot of this stuff seems like it could be put into the upstream build system.

%files
%defattr(644,root,root,755)
%dir %{clusterdir}/platform7/
%{clusterdir}/platform7/*

That's it?  There's no /usr/bin/netbeans?  You need to have a .desktop file at
least too.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list