[Bug 436737] Review Request: php-pear-Mail-mimeDecode - Encodes and Decodes MIME messages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Mail-mimeDecode - Encodes and Decodes MIME messages


https://bugzilla.redhat.com/show_bug.cgi?id=436737





------- Additional Comments From fedora at famillecollet.com  2008-03-29 05:46 EST -------
REVIEW :
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* The spec file name match the base package
* The package must the PHP Packaging Guidelines
* License field in the package spec file DOES NOT match the actual license
* The spec file is written in American English
* The spec file is legible
* build in mock (F-8, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane
* Final Provides ok
php-pear(Mail_mimeDecode) = 1.5.0
php-pear-Mail-mimeDecode = 1.5.0-2.fc8

* Final Requires ok
/usr/bin/pear  
php-pear(Mail_Mime) > 1.4.0
php-pear(PEAR) >= 1.6.0


MUST use epoch for pear BR (to avoid use of php-pear-4.3.9, p.e.) :
BuildRequires:	php-pear >= 1:1.6.0

(note that php-pear(PEAR) >= 1.6.0 is ok, doesn't need epoch)

MUST fix license => BSD (i haven't notice this in Comment #2, sorry)

 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.