[Bug 436637] Review Request: disktype - Detect the content format of a disk or disk image

bugzilla at redhat.com bugzilla at redhat.com
Thu May 1 16:28:43 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: disktype - Detect the content format of a disk or disk image


https://bugzilla.redhat.com/show_bug.cgi?id=436637


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From bugs.michael at gmx.net  2008-05-01 12:28 EST -------
> ifneq ($(LIBEWF),)
>   CPPFLAGS += -DUSE_LIBEWF
>   CFLAGS   += -I/usr/local/include
>   LDFLAGS  += -L/usr/local/lib
>   LIBS     += -lewf
>endif

Why /usr/local? This alters the headers/libraries search path
and can cause non-mock builds to be less reproducible than with
standard search paths. It would be cleaner to not modify the
flags like that.

Else disktype-9-2.fc8.src.rpm from comment 7 is: APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list