[Bug 435623] Review Request: php-pdb - PHP classes for manipulating Palm OS databases

bugzilla at redhat.com bugzilla at redhat.com
Thu May 1 16:53:20 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pdb - PHP classes for manipulating Palm OS databases


https://bugzilla.redhat.com/show_bug.cgi?id=435623


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From bugs.michael at gmx.net  2008-05-01 12:53 EST -------
APPROVED

No run-time testing done.
Only the standard recommendation:

* Prefer "install -p ..." wherever installing pre-built files.

Plus I would move the "-m 644" to the beginning of the install args
and possibly add "-m 0755" when creating the directories.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list