[Bug 445146] Review Request: roadstencil-fonts - Roadstencil fonts
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 4 19:16:20 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: roadstencil-fonts - Roadstencil fonts
https://bugzilla.redhat.com/show_bug.cgi?id=445146
------- Additional Comments From kevin at tummy.com 2008-05-04 15:16 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (OFL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b8d647fb353946263f9de439b8e55bb3 andyfitz_-_roadstencil.otf
b8d647fb353946263f9de439b8e55bb3 roadstencil-fonts-1.0/roadstencil.otf
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
Issues:
1. The upstream website tags this as OFL, so I assume thats the license.
It would be nice if there was a included license or readme saying that with the
font. I'm not sure thats going to be possible with openfontlibrary.org.
Not a blocker.
2. Where did you get the tar.gz?
The Source0 URL seems like it should be:
http://openfontlibrary.org/people/andyfitz/andyfitz_-_roadstencil.otf
3. rpmlint says:
roadstencil-fonts.noarch: W: no-documentation
Can be ignored.
Can you rework things with the Source0 url from item 2?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list