[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

bugzilla at redhat.com bugzilla at redhat.com
Mon May 5 00:18:55 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152





------- Additional Comments From wolfy at nobugconsulting.ro  2008-05-04 20:18 EST -------
It is recommended to use macros instead of using fixed paths. Therefore
"/usr/share/doc/" should be replaced by %{_defaultdocdir} and "/usr/share/man/"
by %{_mandir}

Based on the header of get_cpu.* files, I think that the correct license tag is
GPLv2+.

The presence of the explicit CFLAGS line in the Makefile prohibits the build
process to use the mandatory Fedora compile flags.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list