[Bug 438262] Review Request: beecrypt - An open source cryptography library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beecrypt - An open source cryptography library


https://bugzilla.redhat.com/show_bug.cgi?id=438262


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2008-05-08 16:53 EST -------
Reviewing...

Full review done, results:

Must Fix:
=========

* Drop the java_arches %define and %ifarch's, gcj is available on all Fedora
  supported platforms now a days

* The library gets compiled with -fomit-frame-pointer in the CFLAGS, making 
  debugging it impossible

* The following rpmlint errors:
beecrypt-java.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libbeecrypt_java.so
beecrypt-java.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libbeecrypt_java.so.0.0.0
beecrypt-java.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libbeecrypt_java.so.0.0.0

What is the idea behind this .so, is this a binding for java, and shouldn't it
get installed somewhere under /usr/lib/java then?


Should Fix
==========

* Re-enable c++ bindings, the reason to disable them (not make rpm depend upon
  libstdc++) is no longer valid, and I think that for other beecrypt users 
  beecrypt requering libstdc++ is nothing but a small nuisance.
 
  Note if you do this you must add libicu-devel to the BuildRequires as that
  is required for the c++ stuff


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.