[Bug 446390] Review Request: cluster - RedHat Cluster Suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluster - RedHat Cluster Suite


https://bugzilla.redhat.com/show_bug.cgi?id=446390





------- Additional Comments From fdinitto at redhat.com  2008-05-14 17:18 EST -------
(In reply to comment #7)
> Since you're replacing existing packages, please be sure to coordinate with
> their maintainers and properly End-Of-Life them, according to:
> http://fedoraproject.org/wiki/PackageMaintainers/PackageEndOfLife

All the maintainers of the binary packages I am replacing are in CC in this bug
and we all agreed in advance on this step. I will make sure both Chris and
Steven will obsolete cman/gfs2-utils/rgmanager source packages for rawhide/F10.

Older branches will stay. Once i will be able to access them, they will receive
proper updates as well.

> - rpmlint checks return:
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/qdiskd
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/qdiskd
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/scsi_reserve
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/scsi_reserve
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/cman
> cman.x86_64: W: service-default-enabled /etc/rc.d/init.d/cman
> rgmanager.x86_64: W: service-default-enabled /etc/rc.d/init.d/rgmanager
> rgmanager.x86_64: W: service-default-enabled /etc/rc.d/init.d/rgmanager
> gfs2-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/gfs2
> gfs2-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/gfs2

So this is something i have been pondering myself for a few days now. All the
old .spec files and init.d files had services enabled by default, without
declaring dependencies etc.

These new ones are (in one way or another) all dependent on cman to start
properly and that happens only if cman is configured correctly (otherwise it's a
bug in the init scripts that should be addressed upstream _immediatly_).

cman is not autoconfigured from the packages since there is no such thing as
"cluster default config that will work everywhere" so basically having those
scripts enabled or disabled by default makes no difference.

enabling the services by default will (IMHO) avoid extra steps for the users
given the failsafe embedded in the scripts.

> gfs2-utils.x86_64: W: incoherent-init-script-name gfs2
> 
> The incoherent-init-script-name one is safe to ignore, but you should consider
> whether all of those services should be enabled by default.

Ok thanks. I did confirm this one also checking the recent gfs2-utils review.

> You should correct the license tag for the rgmanager subpackage, as it is
> GPLv2+. Just add:
> 
> License: GPLv2+ into the rgmanager subpackage definition.

Done. On the licensing side, we are working upstream to clean it up and also
provide a proper set of files to land in the %doc areas (usual
COPYING/COPYRIGHT/LICENCES shebang for the whole stack)

> Aside from the License tag and the initscripts, everything is fine. Show me a
> fixed SRPM and I will approve and sponsor.

Spec URL: http://bassotto.seabone.net/~fabbione/cluster.spec
dd1026852f948f97061f5573b27c5085  cluster.spec
SRPM URL: http://bassotto.seabone.net/~fabbione/cluster-2.99.01-3.fc10.src.rpm

> Good work!

Thanks :)

Fabio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.