[Bug 446407] Review Request: unique - unique is a library for writing single instance applications

bugzilla at redhat.com bugzilla at redhat.com
Thu May 15 13:03:50 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unique - unique is a library for writing single instance applications


https://bugzilla.redhat.com/show_bug.cgi?id=446407





------- Additional Comments From dan at danny.cz  2008-05-15 09:03 EST -------
first notes
- add --disable-static to %configure, rm *.a in %install can be then removed
- strip the "%dist" (fc9.hugsie) from the changelog entries
- main %files should contain %{_libdir}/lib*.so.*
- %files devel should contain %{_libdir}/lib*.so (this removes the rpmlint message)
- license should be LGPLv2+ (the sources have "or any later version" clause)
- use full URL for Source0
- BuildRequires
   - dbus-glib-devel takes automagically dbus-devel as BR => remove dbus-devel
   - glibc-headers can be removed too (gcc takes glibc-devel and it takes
glibc-headers, gcc is included in the default buildroot)
- change the Group: from Applications/System to System Environment/Libraries


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list