[Bug 416461] Review Request: xmms-pulse - XMMS output plugin for the PulseAudio sound server.

bugzilla at redhat.com bugzilla at redhat.com
Fri May 16 14:13:15 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  xmms-pulse -  XMMS output plugin for the PulseAudio sound server.


https://bugzilla.redhat.com/show_bug.cgi?id=416461





------- Additional Comments From rnorwood at redhat.com  2008-05-16 10:13 EST -------
o xmms-config comes from xmms-devel, so I think we're ok, there.

o Also, xmms-devel does indeed require xmms-libs:
$ rpm -q --whatrequires xmms-libs
xmms-devel-1.2.10-38.fc9.i386

o I think you're right about the libtool cleanup business.  I get around that by
installing just the files we care about with %{__install} instead of make
install - I suspect using 'make install' and cleaning up like you're doing is
the preferred method.

o lynx is used to generate the docs (lynx --dump), so I have a README.html and a
style.css - not really a big deal at all though if you want to leave those out.
 I see that I forgot to include the ChangeLog in mine.


Henry,

I'd recommend that you take the xmms_outputdir macro from my spec file and use
it in yours, since I think it's nicer than "%{_libdir}/xmms/Output/", but I
don't think any of the other differences matter.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list