[Bug 446097] Review Request: pytraffc - Computer version of the board game Rush Hou

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pytraffc - Computer version of the board game Rush Hou


https://bugzilla.redhat.com/show_bug.cgi?id=446097


geoff at programmer-monk.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoff at programmer-monk.net




------- Additional Comments From geoff at programmer-monk.net  2008-05-17 00:30 EST -------
I'm still pretty new at this so I don't want to be the official reviewer, but here's my unofficial one I 
guess:

Overall the package looks good, I've run down every applicable item in the review guidelines below. Incidentally, I'm the author of gtraffic which inspired pytraffic so it's neat to see this package 
submitted.

 MUST Items:

ok MUST: rpmlint output

  rpmlint is silent

ok MUST: name follows naming guidelines
ok MUST: spec file matches package name
ok MUST: The package must meet the Packaging Guidelines.
ok MUST: license is acceptable
ok MUST: license is correct
ok MUST: license file included in doc
-- MUST: The spec file must be written in American English.

  I suggest changing the puzzle count to 19,000 as that is the American convention

ok MUST: spec file is readable
ok MUST: source matches upstream
ok MUST: package builds successfully
ok MUST: BuildRequires is complete
ok MUST: owns created directories
ok MUST: A package must not contain any duplicate files in the %files listing.
ok MUST: permssions are correct
ok MUST: clean removes buildroot
ok MUST: macros used consistently
ok MUST: package contains code or permissable content
ok MUST: packaged does not depend on %doc files
ok MUST: gui app contains desktop file
ok MUST: doesn't own other package's files
ok MUST: install preps buildroot
ok MUST: All filenames in rpm packages must be valid UTF-8.

 SHOULD Items:

ok SHOULD: license files requested in upstream
-- SHOULD: description and summary transactions
ok SHOULD: builds in mock

  fedora-8-i386 and fedora-9-i386 build okay

-- SHOULD: compile on all supported architectures

  I've only got i386 so I can't test this

ok SHOULD: package works properly
ok SHOULD: subpackages require base package
ok SHOULD: require packages not files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.