[Bug 447191] Review Request: perl-Math-BigInt-GMP - Math::BigInt::GMP Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Math-BigInt-GMP - Math::BigInt::GMP Perl module


https://bugzilla.redhat.com/show_bug.cgi?id=447191


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
            Summary|Review Request: perl-Math-  |Review Request: perl-Math-
                   |BigInt-GMP -                |BigInt-GMP -
                   |Math::BigInt::GMP Perl      |Math::BigInt::GMP Perl
                   |module                      |module
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-05-19 03:04 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=616785
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
de5bb548f9e8e2254565926eec1d15b2  Math-BigInt-GMP-1.24.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01_compile.......
ok
t/02_basic.........
ok
t/03_regression....
ok
t/04_scalar........
ok
t/11_meta_yml......
ok
t/12_plagger.......
ok
t/13_perl_smith....
ok
t/14_yaml_org......
ok
t/15_multibyte.....
ok
t/16_nullrefs......
ok
t/17_toolbar.......
ok
t/97_meta..........
skipped
        all skipped: Author tests not required for installation
t/98_pod...........
skipped
        all skipped: Author tests not required for installation
t/99_pmv...........
skipped
        all skipped: Author tests not required for installation
All tests successful, 3 tests skipped.
Files=14, Tests=221,  1 wallclock secs ( 0.83 cusr +  0.06 csys =  0.89 CPU)

+ Package perl-Parse-CPAN-Meta-0.03-1.fc10 =>
Provides: perl(Parse::CPAN::Meta) = 0.03
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.