[Bug 235929] Review Request: postgresql-odbcng - PostgreSQL ODBCng driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-odbcng -  PostgreSQL ODBCng driver


https://bugzilla.redhat.com/show_bug.cgi?id=235929





------- Additional Comments From devrim at commandprompt.com  2008-05-20 09:45 EST -------
Hi,

(In reply to comment #9)
> Spec in SRPM and URL differ, using URL spec. . .

I have zero idea why this happened. Anyway:
 
> Figured out the md5 issues, the Source0 URL isn't quite right.  Might want to
> explain that in the comments.

I cannot add ?format=raw to Source0 -- current thing is the closest that I can
do -- and ok, added a comment.

> Not sure about the debuginfo issue.  Not a major issue, I don't think.  Might
> want to disable debuginfo creation.

'k, done. 

> License is listed as GPLv2, which is what is included, but the only mention of a
> license in the src is LGPL.

My bad, fixed.
 
> Other than licensing and debuginfo, it passed the rest of the review.

Thanks. I re-uploaded spec and srpm. 

SRPM:

http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.fc9.src.rpm

SPEC:
http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec

Regards, Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.