[Bug 434906] Review Request: xosview - OS resource viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xosview - OS resource viewer


https://bugzilla.redhat.com/show_bug.cgi?id=434906





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-20 14:17 EST -------
Well, for 1.8.3-9:

* Source1
  - Would you write in the spec file what %SOURCE1 come from?
    (when possible, write a full URL)

* ppc64 build failure
  - Well, actually this was because
    * On F-10 redhat-rpm-config (9.0.3-1) %configure does not
      replace config.{sub,status} automatically
      (On F-9 redhat-rpm-config 9.0.2-1) it does replace
    * The original config/config.{sub,status} does not work
      for ppc64

    So something like:
-------------------------------------------------------------
%build
./autogen.sh

# From redhat-rpm-config 9.0.3-1 (F-10) config.{guess,sub} are
# not overwritten automatically. The original config.{guess,sub}
# do not work on ppc64
#
# The following /usr/lib cannot be %%_libdir !!
cp -p /usr/lib/rpm/config.{guess,sub} config/

%configure
%{__make} %{?_smp_mflags} all
--------------------------------------------------------------
    is needed

* %setup not quiet
  - %setup must be quiet (use %setup -q -n XXXXXX)

* Macros
  - Again please fix macros correctly
    %{_prefix}/bin/ -> %{_bindir}
    %{_prefix}/share/man -> %{_mandir}

* %doc
  - Not all README* is needed. README and README.linux is enough.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.