[Bug 447159] Review Request: ocsinventory - Open Computer and Software Inventory Next Generation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocsinventory - Open Computer and Software Inventory Next Generation


https://bugzilla.redhat.com/show_bug.cgi?id=447159


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From xavier at bachelot.org  2008-05-20 15:19 EST -------
 + source files match upstream: 4c582d29db7777506b5cfe49f15af3c4 
OCSNG_UNIX_SERVER_1.02_RC2.tar.gz
 + package meets naming and versioning guidelines.
 + specfile is properly named, is cleanly written and uses macros consistently.
 + dist tag is present.
 + build root is correct.
 + license field matches the actual license.
 + license is open source-compatible.
 + License text included in package.
 + latest version is being packaged.
 + BuildRequires are proper.
 + package builds in mock.
 + package installs properly
 - rpmlint is not silent :
ocsinventory.noarch: W: no-documentation
ocsinventory-reports.noarch: E: non-standard-uid /var/lib/ocsinventory-server apache
ocsinventory-reports.noarch: E: non-standard-uid
/etc/ocsinventory/ocsinventory-reports/dbconfig.inc.php apache
ocsinventory-reports.noarch: E: non-readable
/etc/ocsinventory/ocsinventory-reports/dbconfig.inc.php 0640
ocsinventory-reports.noarch: E: non-standard-uid
/var/lib/ocsinventory-server/download apache
ocsinventory-reports.noarch: E: non-standard-uid
/var/lib/ocsinventory-server/ipd apache
ocsinventory-server.noarch: E: non-standard-uid /var/log/ocsinventory-server apache
ocsinventory-server.noarch: E: non-standard-dir-perm
/var/log/ocsinventory-server 0750
All but the last warning are OK. Please fix perms on /var/log/ocsinventory-server
 - final provides and requires are sane
missing Requires on nmap and samba-client for ocsinventory-reports 
 + owns the directories it creates.
 + doesn't own any directories it shouldn't.
 + no duplicates in %files.
 + file permissions are appropriate.
 + scriptlets are sane.
 + code, not content.
 + documentation is small, so no -docs subpackage is necessary.
 + %docs are not necessary for the proper functioning of the package.
 + not a GUI app.

Items to fix :
- Please fix perms on /var/log/ocsinventory-server.
- Please take care of the directory renaming mentioned in comment #1.
- ipdiscover-util.pl requires nmap and nmblookup, provided respectively by nmap
and samba-client, please add them to ocsinventory-reports requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.