[Bug 447745] Review Request: libusb1 - A library which allows userspace access to USB devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libusb1 - A library which allows userspace access to USB devices


https://bugzilla.redhat.com/show_bug.cgi?id=447745





------- Additional Comments From bnocera at redhat.com  2008-05-23 07:07 EST -------
(In reply to comment #8)
> (In reply to comment #6)
> > Source rpmlint is clean. But:
> > $ rpmlint libusb1-*
> > libusb1.i386: W: no-documentation
> > libusb1-static.i386: W: no-documentation
> > 
> > You need to move the documentation from the -devel package to the main package.
> 
> Hmmm, I don't agree here. The situation is the same as in case of libusb. One
> needs the sole libusb1 package just to run apps that link against it and the
> documentation is put to -devel because it contains exmaples, etc. which a
> Bob-libusb-app-user doesn't need.

Fair enough, but you should at least package the COPYING and AUTHORS file, and
probably the ChangeLog as well in the main package. The first two because they
give copyright/authorship information, and the second because it helps debugging
(ie. if you encounter a new problem, you'd look for the changes version to version).

> > You should add a line mentioning that libsub1 isn't compatible with the original
> > libusb-0.1.
> 
> Added.

OK. I'd change the wording slightly:
"Note that it is incompatible with libusb-0.1 series."
better read:
"Note that this library is not compatible with the original libusb-0.1 series".


Your code to replicate the tarball still isn't correct:
# acquired by:
# git clone git://projects.reactivated.net/~dsd/libusb.git
# and ./autogen.sh; make dist

git clone will just get the tip of the HEAD branch, where you actually want to
be getting an _exact_ commit.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.