[Bug 448215] Review Request: firefox-voikko - Finnish Voikko spell-checker extension for Firefox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox-voikko - Finnish Voikko spell-checker extension for Firefox


https://bugzilla.redhat.com/show_bug.cgi?id=448215





------- Additional Comments From vpivaini at cs.helsinki.fi  2008-05-24 16:31 EST -------
Thanks for the comments.
Updated spec: http://vpv.fedorapeople.org/packages/mozvoikko/firefox-voikko.spec
New SRPM:
http://vpv.fedorapeople.org/packages/mozvoikko/firefox-voikko-0.9.4.1.1-0.2.fc9.src.rpm

(In reply to comment #2)
> - Source0 is not a full URL to the tarball.

Fixed.
 
> - The %{_libdir}/mozilla/extensions/%{firefox_app_id} dir is not owned by this
> package, is it owned by something else in its dependency chain?

Yes, firefox.
 
> - The Makefile patch hardcodes NSPR_INCLUDES=-I/usr/include/nspr4, I think it
> could be changed to something like NSPR_INCLUDES=$(shell pkg-config
> --cflags-only-I nspr)

Changed as recommended.

> - The Makefile patch hardcodes XULRUNNER_SDK=/usr/lib/xulrunner-sdk-1.9pre - is
> that correct on lib64 archs too, and isn't there a pkg-config or something that
> could be called like in the NSPR_INCLUDES comment above?  Ditto for
> VOIKKO_INCLUDES by the way.

That's not correct, because of the current outage I haven't been able to do a
scratch build, so this went unnoticed. The following is used now:
XULRUNNER_SDK=$(shell pkg-config --variable=sdkdir libxul)

Libvoikko is my package, but that doesn't have a pc file, upstream doesn't
provide one either. I can try to add those, but I've never done them before, so
it may take some learning and time (I assume they need to be made during the
build?). However, the location of the header file(s) probably won't be changing
anytime soon, for any arch, so I think just leaving the static value there
should be ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.