[Bug 444755] Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for giving the ordinal form of a number given its cardinal value

bugzilla at redhat.com bugzilla at redhat.com
Thu May 29 10:24:50 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for giving the ordinal form of a number given its cardinal value


https://bugzilla.redhat.com/show_bug.cgi?id=444755


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |xavier at bachelot.org
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From xavier at bachelot.org  2008-05-29 06:24 EST -------
+ source files match upstream : e92078fafd9108a137972c4e9bae9e99
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ %clean is present.
+ package builds in mock.
+ package installs properly
+ rpmlint is silent
+ final provides and requires are sane
+ %check is present and all tests pass
+ owns the directories it creates
- doesn't own any directories it shouldn't.
The directories below are installed and owned :
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN/Numbers
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Lingua/EN/Numbers/Ordinate
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list