[Bug 445105] Review Request: milkytracker - SDL clone of the Fasttracker II module tracker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: milkytracker - SDL clone of the Fasttracker II module tracker


https://bugzilla.redhat.com/show_bug.cgi?id=445105





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-30 07:48 EST -------
Sorry for delay...

(In reply to comment #5)
> * Mon May 26 2008 Joonas Sarajärvi <muepsj at gmail.com> - 0.90.80-2
> - Modified a Makefile.am to not compile the included static zlib library.
> The included Zlib isn't compiled in this release, 

Well, I reviewed your patch, however in fact 
patching against Makefile.am does not do anything, because
configure created Makefile from Makefile.in, not from Makefile.am
and Makefile.in is not automatically regenerated from Makefile.am.

> but the
> zziplib library in Milkytracker seems quite modified to me, 
> and I haven't got MT
> to build with Fedora-provided zziplib.

Would you check the following?
http://koji.fedoraproject.org/koji/taskinfo?taskID=636231
http://koji.fedoraproject.org/scratch/mtasaka/task_636231/

I applied a patch to use system-wide zziplib. milkytracter does not use zlib
directly.


Now I will wait for your another review request submit or pre-review
of other person's review request.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.