[Bug 457926] Review Request: python-wikimarkup - Python module to format text to Mediawiki syntax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457926





--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-01 14:00:48 EDT ---
(In reply to comment #6)
> 1) Should I install the __init__.py in %install section. I am new to packaging 
> so I had a doubt in what you wrote __init_py{,c,o}

  - The reply from Parag will solve this issue. 
    By the way a python skeleton spec file created by rpmdev-newspec says:
----------------------------------------------------------------------
# Remove CFLAGS=... for noarch packages (unneeded)
----------------------------------------------------------------------
    This says that for noarch packages the following line should be
----------------------------------------------------------------------
%{__python} setup.py build
----------------------------------------------------------------------
    as Parag replied (i.e. the part CFLAGS=... should be dropped)

> 2) The revision number to the Source tarball I downloaded should be added right
> ?

  - There doesn't seem to exist any released tarball. You created tarball
    by pulling codes from svn repository and packaging them by using tar
(perhaps).
    In such case also adding revison number to tarball is highly preferred.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.