[Bug 462250] Review Request: Pmw - python megawidgets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462250





--- Comment #3 from Tim Fenn <fenn at stanford.edu>  2008-10-01 19:32:53 EDT ---
Sorry for the late reply, I'm away from home and with a rather spotty
connection.

(In reply to comment #1)
> Some notes.
> 
> * Build failure
>   - Your srpm does not build:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=843287
>     * At least python is needed for BuildRequires
>     * Also even after python is added to BuildRequires the build fails (on
> F-9+) like:
> ----------------------------------------------------------------
> error: Installed (but unpackaged) file(s) found:
>    /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info
> 

Fixed.

> 
> * Redundant definition macro
>   - %python_sitearch is used nowhere
>   - Also it is not needed to define %version, %release macro explicitly.
> 
> * Source URL
>   - %SOURCE must be written with full URL:
>     https://fedoraproject.org/wiki/Packaging/SourceURL
> 

Fixed.

> * The line
> -----------------------------------------------------------------
> [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
> -----------------------------------------------------------------
>   - is not needed. You define $RPM_BUILD_ROOT.

Fixed.

> * Also I think this srpm should be named as "python-pmw":

Done.

spec url: http://www.stanford.edu/~fenn/packs/python-pmw.spec
srpm url: http://www.stanford.edu/~fenn/packs/python-pmw-1.3.2-2.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.