[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #16 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-02 04:52:02 EDT ---
(In reply to comment #13)
> BuildRequires: openmpi-devel
> 
> FYI: Alternatives support in openmpi will probably be gone in next release
> (it's already gone from lam), so you might need something like this in the
> future:
> 
> BuildRequires: environment-modules
> and
> . /etc/profile.d/modules.sh
> module load %{_libdir}/openmpi/*/openmpi.module
> before ./configure with mpi

OK.

Do you have any idea how this works in RHEL5? The newest update includes the
mpi-selector tool, which puts the MPI bin dir into the path.

> export CFLAGS="%optflags -Wa,--noexecstack"
> 
> Could this CFLAGS addition be limited only to files that need it? That'd
> require some Makefile.in patching, of course.

Well, that would be of course nicer, but the flag only operates on assembly
files anyways :)

> However, none of the above are blockers, so feel free to fix them after the
> package is imported. Good work.
> 
> APPROVED

Thanks for bearing with me.

> Based on this package and your reviews of other packages, I'm sponsoring you.
> Please request "packager" group membership in the Fedora Account System and
> I'll approve your request. Welcome aboard!

Done.

(Spec and SRPMS still in the same place.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.