[Bug 464429] Review Request: judy - C Library for Dynamic Sparse Arrays

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464429


Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
         AssignedTo|nobody at fedoraproject.org    |erik-fedora at vanpienbroek.nl
               Flag|                            |fedora-review?




--- Comment #1 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl>  2008-10-03 08:39:54 EDT ---
First impressions:
- The patch 'judy-1.0.4-smp.patch' isn't applied
- There's a comment in the .spec file mentioning '# _smp_mflags not works,
reporte at BZ #2129019'. Bug #2129019 isn't known at this bugzilla. Where can
it be found and is it still open?
- There's a typo in the .spec file: %post -p /sbn/ldconfig. This should be
/sbin/ldconfig
- The %files contains files using wildcards. While this is valid, it is
recommended to use the full filenames for readability.

Full review coming soon

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.