[Bug 463266] Review Request: globalplatform - Access OpenPlatform and GlobalPlatform smart cards library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463266


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-03 12:04:13 EDT ---
Some notes:

* License
  - As far as I check the source codes the license tag
    should be "LGPLv3+".

* SourceURL
  - For tarballs hosted by sourceforge, please refer to:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* Requires
  - GlobalPlatform.h contains:
------------------------------------------------
    44  #include <winscard.h>
    45  #include "unicode.h"
    46  #include <stdio.h>
------------------------------------------------
    So -devel package should have "Requires: pcsc-lite-devel"

  ! By the way it may be preferable that you provide pkgconfig
    file for globalplatform-devel package because winscard.h
    is not under %_includedir but under %_includedir/PCSC so
    to use header files in globalplatform-devel you have
    to add $(pkg-config --cflags libpcsclite) to CFLAGS.

* Documents
  - Please consider to add the following file(s) to %doc:
------------------------------------------------
AUTHORS
------------------------------------------------

* Timestamps
  - Please consider to use
------------------------------------------------
make install DESTDIR=%{buildroot} CPPROG="cp -p"
------------------------------------------------
    to keep timestamps on installed header files?
    This method usually works for Makefiles using install-sh
    when installing files.

* %files entry
  - build log shows:
------------------------------------------------
   521  Processing files: globalplatform-devel-5.0.0-1.fc10
   522  warning: File listed twice:
/usr/include/GlobalPlatform/GlobalPlatform.h
   523  warning: File listed twice: /usr/include/GlobalPlatform/unicode.h
------------------------------------------------
    %files entry
------------------------------------------------
%files
%{_includedir}/GlobalPlatform/
------------------------------------------------
     contains the directory %_includedir/GlobalPlatform itself and
     all files/directories/etc under the directory, so the following
------------------------------------------------
%{_includedir}/GlobalPlatform/*
------------------------------------------------
      entry is not needed. If you want to list only the directory
      %_includedir/GlobalPlatform, use
------------------------------------------------
%dir %{_includedir}/GlobalPlatform/
------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.