[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu>  2008-10-03 12:32:15 EDT ---
I still don't understand how the Summary: helps to clarify much of anything,
but upstream seems to prefer humor over useful documentation so what can we do?
 Maybe consider "Lighter version of the Moose object system", but I don't think
it should hold up approval of this package.

Otherwise everything looks fine to me.

* source files match upstream:
   e075052ab45008e512d78dd340ed62b55923a0faf124887088869b1ae5aa7eaa  
   Mouse-0.09.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Mouse) = 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::Role)
   perl(Mouse::Tiny)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Squirrel)
   perl(Squirrel::Role)
   perl-Mouse = 0.09-1.fc10
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.10.0)
   perl(Carp)
   perl(Class::Method::Modifiers) >= 1.01
   perl(MRO::Compat) >= 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Scalar::Util) >= 1.19
   perl(Test::Exception) >= 0.27
   perl(base)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=46, Tests=2160, 3 wallclock secs
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.