[Bug 462309] Review Request: publican-ovirt - Common documentation files for oVirt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462309





--- Comment #6 from Alan Pevec <apevec at redhat.com>  2008-10-03 12:57:05 EDT ---
(In reply to comment #2)
> Suggestions:-
> 1)Source failed to verify with upstream URL
> 8e60459257b6ec5d43ad34b5cd330a8f  publican-ovirt-0.4.tgz (from upstream URL)
> 2c02784aa82bb23498d9b8f07654ab1d  publican-ovirt-0.4.tgz (from SRPM)
> Re upload SRPM with correct source tarball.

when I did initial SRPM, upstream tarball was not uploaded yet, so I ran make
dist in svn myself, actual diff is uids and timestamps only

> 2) from Packaging Guidelines, consider preserving timestamps 
> http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

considerd, note there are files generated during the build which will have
build-time timestamps

> 3) good if you use defattr usage as
> %defattr(-,root,root,-)

changed, although %defattr(-,root,root) is semantically the same

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.