[Bug 461131] Review Request: sim - Simple Instant Messenger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #37 from Patrice Dumas <pertusus at free.fr>  2008-10-03 20:21:00 EDT ---
(In reply to comment #36)

> > It could. And besides this spec is not only for fedora, it is better 
> > if it is reusable, be it only in EPEL. And it is at best unuseful.
> I'm do not firstly positioning this for any besides Fedora. Well, I'll have
> this on record.

I am only saying that for the Distribution tag; but in general it is
better to avoid using fedora name without good reason, 

http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Avoiding_using_fedora_or_redhat

> > Maybe, but it isn't used during the build? If it is used, I think
> > it is much better to call autoconf/automake/autoreconf explicitly.
> It is used from
> make -f admin/Makefile.common
> after %setup
>
> admin/Makefile.common is upstream file, so I not see any reason copy/past
> content of it into spec.

Ok. There is chance that there are things that are not needed
that are done, but, yes, using  what upstream provides is right.
But then there is this error:
 /usr/bin/autoconf: line 519: echo: write error: Broken pipe

> This check zip in ./configure, and fails if it is not present. Please, see
> buildlog with this report, if you want more details.

It is enough. But it deserves a comment in the spec file in 
my opinion. Looking at the build, it looks like a zip archive is done.

> openssl package also provides few binaries, AFAIK.

If you need openssl for the binaries, please add a comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.