[Bug 462250] Review Request: python-pmw - python megawidgets

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 4 18:12:47 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462250





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-04 14:12:45 EDT ---
For -3:

* %version macro
  - Please consider to use %{version} macro (also see:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* CFLAGS in noarch rpm
  - The part CFLAGS="$RPM_OPT_FLAGS" is not needed because
    this is noarch.

* Macros in %changelog or comments
  - In %changelog or comments, use %% instead of % (e.g.
    "add doc to %%files, add ..") so that macros won't be
    expanded.

Now I am trying to see pymol, however it may take a bit long..

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list