[Bug 461776] Review Request: kde-plasma-quickaccess - Plasma applet for quick access to the most used folders
bugzilla at redhat.com
bugzilla at redhat.com
Sun Oct 5 08:27:43 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461776
Orcan Ogetbil <orcanbahri at yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orcanbahri at yahoo.com
--- Comment #1 from Orcan Ogetbil <orcanbahri at yahoo.com> 2008-10-05 04:27:42 EDT ---
The package is (almost) perfect. Koji build is good too.
http://koji.fedoraproject.org/koji/taskinfo?taskID=861703
Here are my notes:
-------------------------------------------------------------------------
You include a .desktop file in the package. Shouldn't you call some
update-database script to let KDE know that you added something? I'm just
asking (not requiring).
-------------------------------------------------------------------------
According to
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
packages should honor Fedora-specific compiler flags. Make sure that
$RPM_OPT_FLAGS is being honored and used.
-------------------------------------------------------------------------
This is one of my favorite plasma applets. IMHO It should be included in KDE.
Thanks for packaging.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list