[Bug 459455] Review Request: fmit - Free Music Instrument Tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459455


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-05 22:35:58 EDT ---
(In reply to comment #11)
> Removed Requires: per #10, at version fmit-0.97.7-3.fc9

Well,
* I am not sure why this srpm has BuildRequires "qt-devel" (this is qt4) and 
  "qt3-designer" (this is qt3)
* Fedora specific compilation flags are not honored:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=862771
  https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
* When using "cp" or "install" commands, add "-p" option to keep
  timestamps on installed files:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.