[Bug 465740] Review Request: rubygem-gettext - RubyGem of Localization Library and Tools for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465740


Orcan Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orcanbahri at yahoo.com




--- Comment #2 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-10-06 15:21:58 EDT ---
The package looks very good. Here are my notes
-------------------------------------------------------------------------
* The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
   http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
Could you BuildRequire gettext and use the %find_lang macro as depicted in the
Guidelines? Will this cause a problem?
-------------------------------------------------------------------------
* The package does not use the macro's consistently. e.g. the lines
   %{__rm} -rf %{buildroot}%{gemdir}/bin/
   ...
   rm -rf %{buildroot}
cause some inconsistency. 
Also you use the "%{__command}" notation for some commands and "command"
notation for the others. One example: "mv" should be "%{__mv}" if you want to
be consistent.
-------------------------------------------------------------------------
* From http://fedoraproject.org/wiki/Packaging/Ruby  :
The package must have a Requires and a BuildRequires on rubygems
You only have
   BuildRequires:  ruby(rubygems)  
   Requires:  ruby(rubygems)
-------------------------------------------------------------------------
*  Requires:       ruby(rubygems)
   Requires:       irb
Don't you need to require a specific version (or above)?  (just asking)
-------------------------------------------------------------------------
* If the same Ruby library is to be packaged for use as a Gem and as a straight
Ruby library without Gem support, it must be packaged as a Gem first. To make
it available to code that does not use Ruby Gems, a subpackage called
ruby-%{gemname} must be created in the rubygem-%{gemname} package such that

But your straight library is named ruby-%{gemname}-package. Can you explain
why?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.