[Bug 462251] Review Request: PyMOL - python molecular graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #12 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-06 16:58:13 EDT ---
> # The source for this package was pulled from upstream's vcs.  Use the
> # following commands to generate the tarball:
> #  svn co https://pymol.svn.sourceforge.net/svnroot/pymol/branches/b11/pymol pymol-1.1
> #  tar cvzf pymol-1.1-20080912svn3419.tar.gz pymol-1.1
> Source0: pymol-1.1-20080912svn3419.tar.gz

- More exactly:
svn co -r 3419
https://pymol.svn.sourceforge.net/svnroot/pymol/branches/b11/pymol pymol-1.1

so you don't get the current revision.


- Group: Development/Tools

Wouln't Applications/Engineering be a better choice? This is a atomistic
visualisation program, after all. (Applications/Science would of course be
better if it existed..)

- Separate BuildRequires and Requires should be made for each required package. 


- export RPM_OPT_FLAGS="-O2"

Is there some reason not to use %optflags?

- typo %%doc in changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.