[Bug 462251] Review Request: PyMOL - python molecular graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #14 from Gianluca Sforna <giallu at gmail.com>  2008-10-06 17:16:30 EDT ---
(In reply to comment #12)
> - More exactly:
> svn co -r 3419
> https://pymol.svn.sourceforge.net/svnroot/pymol/branches/b11/pymol pymol-1.1
> 
> so you don't get the current revision.

right

> 
> 
> - Group: Development/Tools
> 
> Wouln't Applications/Engineering be a better choice? This is a atomistic
> visualisation program, after all. (Applications/Science would of course be
> better if it existed..)

IIRC the Group tag is not really used these days, groups are composed from
comps.xml, so it's not that really important. 

> - export RPM_OPT_FLAGS="-O2"
> 
> Is there some reason not to use %optflags?

yes, you should use the standard %optflags

> 
> - typo %%doc in changelog.

Nope, in changelog you need to use %% to avoid the macro expansion

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.