[Bug 457207] Review Request: python-cssutils - CSS Cascading Style Sheets library for Python

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 9 15:40:12 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457207





--- Comment #5 from Matthias Saou <matthias at rpmforge.net>  2008-10-09 11:40:11 EDT ---
(In reply to comment #4)

> * Licence has changed:

Good catch!

> * rpmlint reports wrong-file-end-of-line-encoding for %doc files

I had left out the removing of *.tmp files in the hack I had made to convert
docs to the right EOF, those were probably the ones reported as having it wrong
and it should be fixed now.

> * The /usr/bin/css* executables "Requires: python-setuptools" or else
> they traceback!

Another good catch!

> * Group "Applications/Multimedia"? Rather Development/Libraries, but
> the groups are too limited.

True. Changed.

> * The generated html documentation for the API could be put
> into a separate -docs package.

It's only 100kB uncompressed once the *.tmp files are no longer there, so not
worth it IMHO.

Thanks a lot for the review. I've put python-cssutils-0.9.5.1-2 in the same
location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list