[Bug 463266] Review Request: globalplatform - Access OpenPlatform and GlobalPlatform smart cards library

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 9 23:09:26 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463266





--- Comment #6 from François Kooman <fkooman at tuxed.net>  2008-10-09 19:09:25 EDT ---
I updated them again:

Spec URL: http://users.tuxed.net/fkooman/rpmbuild/SPECS/globalplatform.spec
SRPM URL:
http://users.tuxed.net/fkooman/rpmbuild/SRPMS/globalplatform-5.0.0-3.fc10.src.rpm

A few more questions:

- It seems to me that pkg-config --cflags globalplatform should not just return
"-pthread -I/usr/include/PCSC" but something like "-pthread
-I/usr/include/GlobalPlatform -I/usr/include/PCSC" right? So maybe
   includedir=@includedir@
should become:
   includedir=@includedir@/GlobalPlatform 
instead?

- Does it make sense to submit the inclusion of the pkgconfig file upstream (as
the requirement that every patch has a bug report upstream)?

- How about the openssl-devel dependency now that we are moving to NSS? Is this
still allowed? I didn't yet look into how comprehensive the use of openssl
is...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list