[Bug 442270] Review Request: lxde-common - Default artwork and Configuration for LXDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442270





--- Comment #10 from Christoph Wickert <fedora at christoph-wickert.de>  2008-10-09 19:23:19 EDT ---
(In reply to comment #7)
> This package provides /etc/xdg/lxsession/LXDE/default with the following
> contents:
> 
>    smproxy
>    xscreensaver -no-splash
>    openbox --config-file $XDG_CONFIG_HOME/openbox/lxde-rc.xml
>    lxpanel --profile LXDE
>    pcmanfm -d
> 
> 
> Now, smproxy doesn't exist (since you don't require xorg-x11-xsm any more).
> xscreensaver doesn't exist either.
> openbox refuses to start because there is no /etc/xdg/openbox/lxde-rc.xml
> lxpanel also refuses to start, saying the config file doesn't exist.
> pcmanfm does seem to start. Yay! :)

This is not correct:
1. smproxy no longer is required, because lxsession-lite cannot save sessions
(in contrast to lxsession)
2. I don't want to force people to install xscreensaver, because lxde works
fine with other screensavers too. People who install LXDE most likely want a
stripped down desktop environment, perhaps they want to use xlock or no
screensaver at all. /etc/xdg/lxsession/LXDE/default is just a config file that
can be easily changed and the changes are preserved during updates. So I really
don't see a problem here.
3. in /usr/bin/startlxde XDG_CONFIG_HOME is expanded to "$HOME/.config", so
there is no need for /etc/xdg/openbox/lxde-rc.xml
4. startlxde will copy lxde-rc.xml from /usr/share/lxde/openbox/rc.xml to
$XDG_CONFIG_HOME/openbox/lxde-rc.xml (= $HOME/.config/openbox/lxde-rc.xml) if
it does not exist.
5. Same for lxpanel. What you are seeing is a version mismatch problem because
my package has not been touched for a while and the panel config changed to a
new format supporting multiple panels in the meantime.

> When I choose LXDE at the gdm login prompt, I'm presented with a blank screen
> with just the programs I set to start up in my GNOME session (ssh-add, gmpc).
>
> What am I missing?

Try this one, together with the latest lxsession-lite package from bug #442268:
http://cwickert.fedorapeople.org/review/lxde-common-0.3.2.1-2.fc10.src.rpm
http://cwickert.fedorapeople.org/review/lxde-common.spec

I have completely removed the icon-theme and use Echo instead. I will package
nuoveXT as lxde-icon-theme (noarch) later. Since it is not required any longer
by lxsession-lite there is no need to hurry.

I have done my very best to make the new package multi-arch compatible. I'm
preserving timestamps during install and so on, I hope this is for now (until
lxde-settings is splitted out).

If anybody wants to review it, feel free. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.