[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457517





--- Comment #9 from Dan Horák <dan at danny.cz>  2008-10-10 05:45:36 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     d810f98c2b56bb54d89d1a41596d8fbddfdf699c  Padre-0.10.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A* %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
BAD* doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
BAD is a GUI app, desktop file is missing

- rpmlint complains
perl-Padre.noarch: E: script-without-shebang
/usr/lib/perl5/vendor_perl/5.10.0/Padre/Wx/Ack.pm
    remove the executable bits
perl-Padre.noarch: E: non-executable-script
/usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl
0644
perl-Padre.noarch: E: non-executable-script
/usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.t
0644
    when /auto/share/dist/Padre/templates/* must be packaged (it is required
for Padre to work correctly), then you should package 2 dirs
    %{perl_vendorlib}/Padre + %{perl_vendorlib}/auto/share/dist/Padre, but not
the whole %{perl_vendorlib}/* hierarchy
- tests requires running X, so the check section is disabled, but the proper
BR: can exist in the spec (commented out)
- it is a GUI application, but desktop file is missing
- when running Padre in mock/Rawhide I got an error "libwx_gtk2u_stc-2.8.so:
cannot open shared object file: No such file or directory", window title
"Padre::Wx::App Error" - looks like something wants to open development version
of this library even when the runtime lib is installed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.