[Bug 445537] Review Request: tightvnc - VNC software

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 10 12:37:06 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=445537





--- Comment #7 from Dan HorĂ¡k <dan at danny.cz>  2008-10-10 08:37:05 EDT ---
few notes
- you can use "svn export" instead of "svn checkout" (or a even script like
http://fedora.danny.cz/fedora-getsvn), the source archive will be smaller, but
when you are using upstream released snapshots, use them
- the EVRs in Obsoletes/Provides are inconsistent between main package and
-server subpackage and I don't think that the main package should contain
Obsol/Prov for vnc-server
- better use --with-os-name="Fedora" in xserver's %configure (instead of
"Fedora 11")
- replace /etc with %{_sysconfdir}, /etc/rc.d/init.d with %{_initddir} in
%build and %install sections
- don't add X-Red-Hat-Extra into desktop file, fix the file directly instead of
using command line options, use fedora as vendor, missing BR:
desktop-file-utils - more about desktop files at
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list