[Bug 446800] Review Request: ebnetd - EBNET protocol server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=446800


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
               Flag|                            |fedora-review?




--- Comment #4 from Jon Ciesla <limb at jcomserv.net>  2008-10-10 10:41:06 EDT ---
What's comment #3 about?

Anyway. . .

rpmlint on SRPM is clean.

rpmlint on RPMS:

ebhttpd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ebnetd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ebnetd-common.i386: W: non-standard-uid /var/lib/ebnetd ebnetd
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.

ebnetd-common.i386: W: non-standard-gid /var/lib/ebnetd ebnetd
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

ebnetd-common.i386: W: non-standard-uid /var/run/ebnetd ebnetd
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.

ebnetd-common.i386: W: non-standard-gid /var/run/ebnetd ebnetd
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

ndtpd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.



These are all fine, see above.

Otherwise, everything looks great, my only other concern after a full review is
the Conflicts: for ebhttpd.  Will users expect this to be on port 80 by
default, period, full stop, or would it be feasible to set it to use something
else by default, or recommend that to users?  It'd be as simple as modifying
the xinetd file.  My preference would be to leave it as is, drop the
Conflicts:, but add a ebnetd-README.fedora indicating the port 80 issues and
resolutions, so that if someone wants to use this on a machine with an existing
httpd/tux/whatever, then they have that option and won't be stopped by the RPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.