[Bug 463266] Review Request: globalplatform - Access OpenPlatform and GlobalPlatform smart cards library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463266





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-10 11:25:18 EDT ---

For -3:

(In reply to comment #6)
> A few more questions:
> 
> - It seems to me that pkg-config --cflags globalplatform should not just return
> "-pthread -I/usr/include/PCSC" but something like "-pthread
> -I/usr/include/GlobalPlatform -I/usr/include/PCSC" right? So maybe
>    includedir=@includedir@
> should become:
>    includedir=@includedir@/GlobalPlatform 
> instead?
  - Oh, I overlooked this point. The correct one is
---------------------------------------------------------------
Cflags: -I${includedir}/GlobalPlatform
---------------------------------------------------------------

> - Does it make sense to submit the inclusion of the pkgconfig file upstream (as
> the requirement that every patch has a bug report upstream)?
  - I think shipping pkgconfig file in the tarball is preferable (for
    this package) and I would appreciate it if you submit to upstream.

> - How about the openssl-devel dependency now that we are moving to NSS? Is this
> still allowed? 
  - I think if openssl is to be removed from Fedora there will be such
    an announce.

Then:
* Dependency for -devel subpackage
  - Every package which contains pkgconfig .pc file should
    have "Requires: pkgconfig" so please add this to -devel subpackage.

And I will wait for your another review request submit or your
pre-review of other person's review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.