[Bug 458338] Review Request: DivFix++ - A program to repair broken AVI file streams by rebuilding index part of file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458338





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-10 12:02:14 EDT ---


(In reply to comment #5)
> (In reply to comment #4)
> > * Macros
> > > >   - %distname is not defined.
> > > %distname replaced by %{distribution}
> > 
> >   - My system does not define %distribution macro. Koji seems to
> >     define it, however its value (string) is "Unknown" so
> >     this is still wrong.
> >     Just use "--vendor=fedora".
> Hmmm. What about this
> http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Avoiding_using_fedora_or_redhat
> recommendation to opposite do NOT using names like Fedora o Redhat in spec???

  - This item says that naming a document as "README.fedora" or so
    should be avoided, however I oppose to it because there are many
    Fedora specific packaging issue...
    Also this item says that "Of course this doesn't cover internal 
    details like spec file conditionals like %fedora or %rhel."
    So please use --vendor=fedora.

    ! Note
      Currently not a few maintainers simply remove "--vendor=foo"
      when using desktop-file-install. If you remove this completely
      I don't oppose to it

> And lso in this dociment I get macros %{distribution}...
  - But actually on my system %distribution is not defined and
    koji (Fedora build server) sets this as "Unknown"...

* Category of desktop file
  - As you create the base desktop file by yourself, you can simply
    add 
------------------------------------------------
Category=Video;
------------------------------------------------
    line between "%{__cat} > %{name}.desktop << EOF"
    and EOF lines, then remove "--add-category=Video"
    ! Note
      - Semicolon is needed at the last.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.