[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 11 00:04:42 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372





--- Comment #2 from Conrad Meyer <konrad at tylerc.org>  2008-10-10 20:04:41 EDT ---
> I can't see why you don't use the initial Makefile.

The initial Makefile seemed horribly broken enough to warrant replacement (-m32
among other things!). If it builds using correct Fedora flags with make like
you suggest I don't see any problem using the original Makefile though.

> openssl in requires is not useful, it is automatically found by rpm.

Ok.

> It is better to avoid using Fedora whenever possible, so please rename
> README.Fedora to something more neutral like README.Dist
> cp should be cp -p to keep timestamp.
> Also I suggest using %{_mandir}/man8/%{name}.8* to catch any kind of 
> compression.

Ok.

> I am afraid that, if accepted, you'll need contact legal (through spot,
> he is the contact) because of the crypto and export stuff.

I'll contact him.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list