[Bug 464430] Review Request: ltsp-server-livesetupdocs - Doc describing how to enable LTSP on Fedora Live LTSP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464430


Warren Togami <wtogami at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wtogami at redhat.com




--- Comment #3 from Warren Togami <wtogami at redhat.com>  2008-10-12 02:59:59 EDT ---
https://fedoraproject.org/wiki/Packaging/Guidelines
I took a look at the spec file.  Did you even read the Fedora packaging
guidelines?

A few suggestions:
* Start from scratch using a .spec template from
/etc/rpmdevtools/spectemplate*.spec from the rpmdevtools package.
* The source tarball, include a version number within the tarball name. 
Generally like name-version.tar.bz2.
* Do not include a Packager tag.
* https://fedoraproject.org/wiki/Packaging/RPMMacros
  Replace path names like /etc and /usr/share with macros from this page.

You should also want to run rpmlint on both the .src.rpm and .noarch.rpm. 
Correct everything that it complains about.

[warren at newcaprica tmp]$ rpmlint ltsp-server-livesetupdocs-0.1-0.src.rpm 
ltsp-server-livesetupdocs.src:10: W: hardcoded-packager-tag
peter at scheie.homedns.org
ltsp-server-livesetupdocs.src: W: no-%build-section
ltsp-server-livesetupdocs.src: E: no-changelogname-tag
ltsp-server-livesetupdocs.src: W: invalid-license GPL
ltsp-server-livesetupdocs.src: W: no-url-tag
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Assigning package review to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.