[Bug 457281] Review Request: unikurd-fonts - A widely used Kurdish font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457281


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |besfahbo at redhat.com
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |needinfo?(mnowak at redhat.com
                   |                            |)




--- Comment #5 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2008-10-12 12:22:11 EDT ---
(In reply to comment #2)
> --unofficial review--

Thank you for the nice unofficial review Ankur, I'll take up from there.

Michal: The spec is an almost perfect copy from official guidelines, that makes
it easy to review, thanks

Blocking remarks

1. unless upstream has confirmed 1.0 is the actual font revision, and it will
version further updates, please use 20020502 as version
⇒ check the version

2. Please add a fontconfig file as Ankur suggested. Since unikurd covers
unicode blocks Behdad is interested in, I think it shouldn't be too hard to get
him to help you (I doubt he wants you to stomp on farsi)
⇒ add some fontconfig rules

3. unless you *know* upstream is going to release new fonts in the same
archive, there is no need to prepare for subpackaging. Upstream is just as
likely to publish separate archives, which will mean separate packages (see the
gfs fonts for examples). If upstream does end up adding new fonts to this very
archive, you can always go the obsolete route
⇒ drop the "just in case" subpackaging

Non blocking remarks

1. please have upstream add the GPL font exception to their font
2. please have upstream provide sfd sources if they use fontforge

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.